build,windows: make vcbuild fail if upload fails

[refack]

Refs: nodejs/build#1211

Crood solution but effective.

Output before:

d:\code\node$ vcbuild nobuild noprojgen upload
Looking for Python 2.x
ssh: Could not resolve hostname node-www: Name or service not known
ssh: Could not resolve hostname node-www: Name or service not known
lost connection
ssh: Could not resolve hostname node-www: Name or service not known
lost connection
ssh: Could not resolve hostname node-www: Name or service not known
lost connection
ssh: Could not resolve hostname node-www: Name or service not known
lost connection
ssh: Could not resolve hostname node-www: Name or service not known
lost connection
ssh: Could not resolve hostname node-www: Name or service not known
lost connection
ssh: Could not resolve hostname node-www: Name or service not known
lost connection
ssh: Could not resolve hostname node-www: Name or service not known

Output after:

d:\code\node$ vcbuild nobuild noprojgen upload
Looking for Python 2.x
ssh: Could not resolve hostname node-www: Name or service not known

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes — manual
• commit message follows commit guidelines

[rvagg]

nice, do you know if errorlevel will propagate outside of the script so Jenkins will mark a build as failed?

[refack]

do you know if errorlevel will propagate

It should (since nothing sets or resets it until the batch exits), and it did in my manual test. But in the wild cmd will do whatever cmd likes...

[refack]

BTW:

if errorlevel 1 ...

means if %ERRORLEVEL% is greater or equal to 1. Another wonderful cmdism.

[BridgeAR]

I guess there is no CI that makes sense to run for this?

[rvagg]

Yeah, there is actually, I've kicked off a test build which should come out @ https://nodejs.org/download/test/ as v10.0.0-test201804064cc80f32f9, the .msi and win-X directories will be the interesting part, plus also we'll have to check Jenkins to make sure we got green and the logs for the Windows builds look good. Someone with access will have to look @ https://ci-release.nodejs.org/job/iojs+release/3287/, I think @refack has access to do that right? I'll be 💤 soon and will have forgotten about this tomorrow.

[rvagg]

https://nodejs.org/download/test/v10.0.0-test201804064cc80f32f9/ got a success from both windows builders, I see the x86 files in there now, the x64 ones should show up within the next 15 minutes. @refack you should have a look and make sure they are all there and work properly.

[refack]

@refack you should have a look and make sure they are all there and work properly.

All expected files are accounted for and valid (SHA256, and 7z tested).

[joaocgreis]

This is a safety net that should be present in all branches, added the lts-watch labels.