Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove unused util.h from tls_wrap.h #19849

Closed
wants to merge 1 commit into from
Closed

src: remove unused util.h from tls_wrap.h #19849

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Apr 6, 2018

This commit removes util.h from tls_wrap.h and adds util-inl.h to
tls_wrap.cc which does use it.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@danbev
src: remove unused util.h from tls_wrap.h
ef6ec89 
This commit removes util.h from tls_wrap.h and adds util-inl.h to
tls_wrap.cc which does use it.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. tls Issues and PRs related to the tls subsystem. labels Apr 6, 2018
@danbev
Copy link
Contributor Author

danbev commented Apr 6, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/14088/

@danbev
Copy link
Contributor Author

danbev commented Apr 6, 2018

Re-run https://ci.nodejs.org/job/node-test-commit-plinux/16662/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 8, 2018
@tniessen
Copy link
Member

tniessen commented Apr 9, 2018

Landed in 3650972.

@tniessen tniessen closed this Apr 9, 2018
tniessen pushed a commit that referenced this pull request Apr 9, 2018
@danbev @tniessen
src: remove unused util.h from tls_wrap.h
3650972 
This commit removes util.h from tls_wrap.h and adds util-inl.h to
tls_wrap.cc which does use it.

PR-URL: #19849
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Apr 12, 2018
@danbev @targos
src: remove unused util.h from tls_wrap.h
8d2ca73 
This commit removes util.h from tls_wrap.h and adds util-inl.h to
tls_wrap.cc which does use it.

PR-URL: #19849
Reviewed-By: James M Snell <jasnell@gmail.com>
@danbev danbev deleted the tls_wrap-remove-unused-include branch May 31, 2018 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@danbev @tniessen @jasnell @BridgeAR @nodejs-github-bot