Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: move evanlucas to TSC Emeritus #19953

Merged
merged 1 commit into from
Apr 11, 2018
Merged

doc: move evanlucas to TSC Emeritus #19953

merged 1 commit into from
Apr 11, 2018

Conversation

evanlucas
Copy link
Contributor

I no longer have the time to dedicate to being on the TSC.
I am still planning to contribute when time permits.

Thanks to everyone who works on node regularly. :]

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 11, 2018
Trott
Trott approved these changes Apr 11, 2018
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will miss your presence on the TSC, but thanks for setting a good example and stepping away when it makes sense. Thanks for all you've done and see you around!

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 11, 2018
@Trott
Copy link
Member

Trott commented Apr 11, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/491/

@Trott
Copy link
Member

Trott commented Apr 11, 2018

@nodejs/tsc

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 11, 2018
cjihrig
cjihrig approved these changes Apr 11, 2018
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for everything Evan!

ofrobots
ofrobots approved these changes Apr 11, 2018
View reviewed changes
Copy link
Contributor

@ofrobots ofrobots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for everything @evanlucas!

gibfahn
gibfahn approved these changes Apr 11, 2018
View reviewed changes
Copy link
Member

@gibfahn gibfahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

MylesBorins
MylesBorins approved these changes Apr 11, 2018
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MISSS YOUUUU

@bnb
Copy link
Contributor

bnb commented Apr 11, 2018

Thanks for all your contributions, @evanlucas ❤️

Fishrock123
Fishrock123 approved these changes Apr 11, 2018
View reviewed changes
Copy link
Contributor

@Fishrock123 Fishrock123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for everything!

@evanlucas
doc: move evanlucas to TSC Emeritus
814d034 
I no longer have the time to dedicate to being on the TSC.
I am still planning to contribute when time permits.

PR-URL: nodejs#19953
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@evanlucas evanlucas closed this Apr 11, 2018
@evanlucas evanlucas deleted the moveme branch April 11, 2018 22:09
@evanlucas evanlucas merged commit 814d034 into nodejs:master Apr 11, 2018
@evanlucas
Copy link
Contributor Author

Landed in 814d034

targos pushed a commit that referenced this pull request Apr 12, 2018
@evanlucas @targos
doc: move evanlucas to TSC Emeritus
e306721 
I no longer have the time to dedicate to being on the TSC.
I am still planning to contribute when time permits.

PR-URL: #19953
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
jasnell pushed a commit that referenced this pull request Apr 16, 2018
@evanlucas @jasnell
doc: move evanlucas to TSC Emeritus
4c70616 
I no longer have the time to dedicate to being on the TSC.
I am still planning to contribute when time permits.

PR-URL: #19953
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Fishrock123 Fishrock123 Fishrock123 approved these changes

@Trott Trott Trott approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

@ofrobots ofrobots ofrobots approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@evanlucas @Trott @bnb @ofrobots @MylesBorins @Fishrock123 @cjihrig @gibfahn @nodejs-github-bot