buffer: do not always use defaults #20054
Closed
+233
−238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Buffer#(read|write)U?Int(B|L)E functions should not use a default value. This is very likely a bug and it was never documented that way. Besides that this also improves the tests by adding more tests and by refactoring them to less code lines.
BridgeAR
added
the
semver-major
nodejs-github-bot
added
the
buffer
BridgeAR
added
the
author ready
XadillaX
approved these changes
Apr 16, 2018
|
LGTM I suppose, seems a bit late to be squeezing something like this into 10 though |
jasnell
approved these changes
Apr 16, 2018
trivikr
approved these changes
Apr 18, 2018
ChALkeR
approved these changes
Apr 18, 2018
There was a problem hiding this comment.
LGTM.
Nit though: part of test style changes look unrelated, and I am not sure if those should be done in a semver-major commit. /cc @MylesBorins
|
@ChALkeR I can split the tests into a different PR if you want. But since it is work: are you fine with landing it as is? |
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Apr 29, 2018
The Buffer#(read|write)U?Int(B|L)E functions should not use a default value. This is very likely a bug and it was never documented that way. Besides that this also improves the tests by adding more tests and by refactoring them to less code lines. PR-URL: nodejs#20054 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
|
No one complaint in the last 11 days, so I went ahead and landed it as is. Landed in 60b5b38 |
targos
added a commit
to targos/node
that referenced
this pull request
Jun 6, 2018
Backport of a changed test from nodejs#20054
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Buffer#(read|write)U?Int(B|L)E functions should not use a default
value. This is very likely a bug and it was never documented that
way.
I checked this against gzemnid and it did not show a single module using
this pattern. I personally say it is a bug if the user calls these functions
without arguments, because it is not clear what happens.
Besides that this also improves the tests by adding more tests and by
refactoring them to less code lines.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes