Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: make c, ca and certs const in _tls_common #20073

Closed
wants to merge 2 commits into from
Closed

lib: make c, ca and certs const in _tls_common #20073

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0443f11
lib: make c, ca and certs const in _tls_common
danbev Apr 16, 2018
ecf4c5e
squash: use object destructuring for ca and cert
danbev Apr 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/_tls_common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,15 +88,15 @@ exports.createSecureContext = function createSecureContext(options, context) {
if (options.honorCipherOrder)
secureOptions |= SSL_OP_CIPHER_SERVER_PREFERENCE;

var c = new SecureContext(options.secureProtocol, secureOptions, context);
const c = new SecureContext(options.secureProtocol, secureOptions, context);
var i;
var val;

if (context) return c;

// NOTE: It's important to add CA before the cert to be able to load
// cert's issuer in C++ code.
var ca = options.ca;
const { ca } = options;
if (ca) {
if (Array.isArray(ca)) {
for (i = 0; i < ca.length; ++i) {
Expand All @@ -112,7 +112,7 @@ exports.createSecureContext = function createSecureContext(options, context) {
c.context.addRootCerts();
}

var cert = options.cert;
const { cert } = options;
if (cert) {
if (Array.isArray(cert)) {
for (i = 0; i < cert.length; ++i) {
Expand Down