Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: assert tmp and fixture dirs different #2015

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jun 19, 2015

I suspect the todo comment eliminated here is obsolete and/or overkill, but assert() put in place just in case...

CI: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/56/

@mscdex mscdex added fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests. labels Jun 19, 2015
@Trott
Copy link
Member Author

Trott commented Jun 22, 2015

Anyone feel like weighing in with a "LGTM" or a "OMGWTFBBQNO!!!"? Or a "SHRUG"? /ping @nodejs/collaborators

@trevnorris
Copy link
Contributor

Oh good crap. That comment is from 2010.

LGTM

Trott added a commit to Trott/io.js that referenced this pull request Jun 22, 2015
PR-URL: nodejs#2015
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@Trott
Copy link
Member Author

Trott commented Jun 22, 2015

Merged in 5d2b846

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants