buffer: fix deprecation warning emit #20163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to npm using workers on Windows which inititate processes for code within node_modules, the current way of testing is a little too strict to catch all occurrences.
apapirovski
added
buffer
nodejs-github-bot
added
the
util
|
CI: https://ci.nodejs.org/job/node-test-pull-request/14396/ (You can also 👍 for fast-track.) |
cjihrig
approved these changes
Apr 20, 2018
JungMinu
approved these changes
Apr 20, 2018
addaleax
approved these changes
Apr 20, 2018
|
If possible I would like to get some fast-track approvals so @jasnell can get this in his RC build today. Currently we only have 1. Thanks everyone! |
addaleax
added
the
author ready
|
+1 to fast-track if it wasn’t clear. |
apapirovski
added a commit
that referenced
this pull request
Apr 20, 2018
Due to npm using workers on Windows which inititate processes for code within node_modules, the current way of testing is a little too strict to catch all occurrences. PR-URL: #20163 Fixes: #20160 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
|
Landed in d718d53. Thanks everyone! |
|
@jasnell this needs to be pulled into 10.0.0 today. Thanks! |
|
Can you please make sure it's added to the 10.0.0 milestone? I can't do so myself at the moment. |
|
@jasnell Yep, it's on there. Along with the other regression fix. |
jasnell
pushed a commit
that referenced
this pull request
Apr 20, 2018
Due to npm using workers on Windows which inititate processes for code within node_modules, the current way of testing is a little too strict to catch all occurrences. PR-URL: #20163 Fixes: #20160 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to npm using workers on Windows which inititate processes for code within node_modules, the current way of testing is a little too strict to catch all occurrences.
I understand that the previous implementation was there for a reason but as far as I can tell it's also likely to get a lot of other false positives than just the
npm installissue — such as running code innode_modules/.bin/.Fixes: #20160
Refs: https://github.com/npm/npm/blob/8452a9d9b231bc6c95745bb49a4b838ce11d3b9c/lib/install/action/extract.js#L22-L34
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes