Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve http res write and end dont take array #20199

Closed
wants to merge 1 commit into from
Closed

test: improve http res write and end dont take array #20199

wants to merge 1 commit into from

Conversation

ilsotov
Copy link
Contributor

@ilsotov ilsotov commented Apr 21, 2018 •
edited
Loading

Checking if the error thrown in res.write and res.end is ERR_INVALID_ARG_TYPE if arg is array.

Checklist

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 21, 2018
@lpinca
Copy link
Member

lpinca commented Apr 21, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/14417/

@lpinca lpinca added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 21, 2018
trivikr pushed a commit that referenced this pull request Apr 23, 2018
@ilsotov @trivikr
test: improve http res write and end dont take array
12b90b4 
PR-URL: #20199
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@trivikr
Copy link
Member

trivikr commented Apr 23, 2018

Landed in 12b90b4

Congratulations @ilsotov on your first commit to Node.js core! 🎉🎉🎉

@trivikr trivikr closed this Apr 23, 2018
@ilsotov ilsotov deleted the test-res-write-and-end-dont-take-arr branch April 23, 2018 15:34
jasnell pushed a commit that referenced this pull request Apr 23, 2018
@ilsotov @jasnell
test: improve http res write and end dont take array
0ddc060 
PR-URL: #20199
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ilsotov @lpinca @trivikr @Trott @BridgeAR @nodejs-github-bot