-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: improve fatal exception #20294
src: improve fatal exception #20294
Conversation
This is just some code cleanup.
src/node.cc
Outdated
|
||
if (exit_code == 0 && false == caught->BooleanValue()) { | ||
exit(7); | ||
} else if (false == caught->BooleanValue()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we either un-yoda-ize this and make it use the non-deprecated overload of BooleanValue
, or switch to if (caught->IsFalse())
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed
CI-Lite: https://ci.nodejs.org/job/node-test-pull-request-lite/597/ (should be enough to reconfirm). |
Landed in b87ef18 |
This is just some code cleanup. PR-URL: #20294 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This is just some code cleanup. PR-URL: #20294 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This is just some code cleanup.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes