Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: improve fatal exception #20294

Closed
wants to merge 2 commits into from

Conversation

BridgeAR
Copy link
Member

This is just some code cleanup.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

This is just some code cleanup.
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Apr 25, 2018
@BridgeAR
Copy link
Member Author

src/node.cc Outdated

if (exit_code == 0 && false == caught->BooleanValue()) {
exit(7);
} else if (false == caught->BooleanValue()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we either un-yoda-ize this and make it use the non-deprecated overload of BooleanValue, or switch to if (caught->IsFalse())?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed

@BridgeAR
Copy link
Member Author

CI-Lite: https://ci.nodejs.org/job/node-test-pull-request-lite/597/ (should be enough to reconfirm).

@lpinca lpinca added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 26, 2018
@addaleax addaleax added the lib / src Issues and PRs related to general changes in the lib or src directory. label Apr 27, 2018
@addaleax
Copy link
Member

Landed in b87ef18

@addaleax addaleax closed this Apr 27, 2018
@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 27, 2018
addaleax pushed a commit that referenced this pull request Apr 27, 2018
This is just some code cleanup.

PR-URL: #20294
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 4, 2018
This is just some code cleanup.

PR-URL: #20294
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request May 8, 2018
@BridgeAR BridgeAR deleted the improve-fatal-exception branch January 20, 2020 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants