doc: Fix v8 doc headings so 'make doc' passes #203
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the code that builds the Table of Contents threw an exception because of jump from an H1 heading directly to an H3 heading. By changing the H3 heading to an H2, 'make doc' works again. This is also consistent with other docs like console.markdown which use H2 for method call documentation.
bnoordhuis
pushed a commit
that referenced
this pull request
Dec 23, 2014
Previously the code that builds the Table of Contents threw an exception because of jump from an H1 heading directly to an H3 heading. By changing the H3 heading to an H2, 'make doc' works again. This is also consistent with other docs like console.markdown which use H2 for method call documentation. PR-URL: #203 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
Oops and mea culpa, I guess I broke that when I converted the documentation for the tracing module. Landed in 0a8e987, thanks! |
jasongin
added a commit
to jasongin/nodejs
that referenced
this pull request
Mar 28, 2017
- Add an env parameter to napi_finalize - Remove unnecessary reinterpret_cast<> calls - Remove redundant Maybe.IsNothing() checks - Make function call result parameters optional - Wrap internal field pointer values in External - Fix broken callback tests and add error-checking - Other misc test cleanup
boingoing
pushed a commit
to boingoing/node
that referenced
this pull request
Apr 6, 2017
- Add an env parameter to napi_finalize - Remove unnecessary reinterpret_cast<> calls - Remove redundant Maybe.IsNothing() checks - Make function call result parameters optional - Wrap internal field pointer values in External - Fix broken callback tests and add error-checking - Other misc test cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the code that builds the Table of Contents threw
an exception because of jump from an H1 heading directly to an H3
heading. This happened when running
make doc.By changing the H3 heading to an H2, 'make doc' works again. This is
also consistent with other docs like console.markdown which use
H2 for method call documentation.