doc: remove os.uptime() Windows note #20308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The libuv 1.20.2 update in Node 10 aligned the Windows behavior of os.uptime() with that of other operating systems. The return value no longer contains a fraction component. Refs: nodejs#20129
nodejs-github-bot
added
doc
vsemozhetbyt
approved these changes
Apr 25, 2018
vsemozhetbyt
added
the
fast-track
|
Please, add 👍 here to approve fast-tracking. |
richardlau
approved these changes
Apr 25, 2018
vsemozhetbyt
added
the
author ready
BridgeAR
approved these changes
Apr 25, 2018
trivikr
approved these changes
Apr 26, 2018
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Apr 26, 2018
The libuv 1.20.2 update in Node 10 aligned the Windows behavior of os.uptime() with that of other operating systems. The return value no longer contains a fraction component. Refs: nodejs#20129 PR-URL: nodejs#20308 Refs: nodejs#20129 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
|
Landed in 124875c 🎉 |
MylesBorins
pushed a commit
that referenced
this pull request
May 4, 2018
The libuv 1.20.2 update in Node 10 aligned the Windows behavior of os.uptime() with that of other operating systems. The return value no longer contains a fraction component. Refs: #20129 PR-URL: #20308 Refs: #20129 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Aug 7, 2018
The libuv 1.20.2 update in Node 10 aligned the Windows behavior of os.uptime() with that of other operating systems. The return value no longer contains a fraction component. Refs: #20129 PR-URL: #20308 Refs: #20129 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The libuv 1.20.2 update in Node 10 aligned the Windows behavior of
os.uptime()with that of other operating systems. The return value no longer contains a fraction component.Refs: #20129
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes