Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix todos #20319

Closed
wants to merge 5 commits into from
Closed

test: fix todos #20319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
46e2f50
test: remove obsolete TODOs
BridgeAR Apr 26, 2018
1f204dd
test: add fs.copyFile test
BridgeAR Apr 26, 2018
b6b64d9
fixup: remove another TODO
BridgeAR Apr 26, 2018
d09cb70
fixup: address test failure
BridgeAR Apr 26, 2018
83f63f1
fixup: add todo
BridgeAR Apr 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions lib/url.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,9 +281,6 @@ Url.prototype.parse = function parse(url, parseQueryString, slashesDenoteHost) {
// http://a@b@c/ => user:a@b host:c
// http://a@b?@c => user:a host:b path:/?@c

// v0.12 TODO(isaacs): This is not quite how Chrome does things.
// Review our test case against browsers more comprehensively.

var hostEnd = -1;
var atSign = -1;
var nonHost = -1;
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-cluster-http-pipe.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ if (cluster.isMaster) {
http.createServer(common.mustCall((req, res) => {
assert.strictEqual(req.connection.remoteAddress, undefined);
assert.strictEqual(req.connection.localAddress, undefined);
// TODO common.PIPE?

res.writeHead(200);
res.end('OK');
Expand Down
23 changes: 11 additions & 12 deletions test/parallel/test-fs-error-messages.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -636,22 +636,21 @@ if (!common.isAIX) {
);
}

// copyFile with invalid flags
// Check copyFile with invalid flags.
{
const validateError = (err) => {
assert.strictEqual(err.message,
'EINVAL: invalid argument, copyfile ' +
`'${existingFile}' -> '${nonexistentFile}'`);
assert.strictEqual(err.errno, uv.UV_EINVAL);
assert.strictEqual(err.code, 'EINVAL');
assert.strictEqual(err.syscall, 'copyfile');
return true;
const validateError = {
// TODO: Make sure the error message always also contains the src.
message: `EINVAL: invalid argument, copyfile -> '${nonexistentFile}'`,
errno: uv.UV_EINVAL,
code: 'EINVAL',
syscall: 'copyfile'
};

// TODO(joyeecheung): test fs.copyFile() when uv_fs_copyfile does not
// keep the loop open when the flags are invalid.
// See https://github.com/libuv/libuv/pull/1747
fs.copyFile(existingFile, nonexistentFile, -1,
common.expectsError(validateError));

validateError.message = 'EINVAL: invalid argument, copyfile ' +
`'${existingFile}' -> '${nonexistentFile}'`;
assert.throws(
() => fs.copyFileSync(existingFile, nonexistentFile, -1),
validateError
Expand Down
2 changes: 0 additions & 2 deletions test/parallel/test-util-isDeepStrictEqual.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,8 +419,6 @@ notUtilIsDeepStrict([1, , , 3], [1, , , 3, , , ]);
const err3 = new TypeError('foo1');
notUtilIsDeepStrict(err1, err2, assert.AssertionError);
notUtilIsDeepStrict(err1, err3, assert.AssertionError);
// TODO: evaluate if this should throw or not. The same applies for RegExp
// Date and any object that has the same keys but not the same prototype.
notUtilIsDeepStrict(err1, {}, assert.AssertionError);
}

Expand Down