Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Fix for Issue #17668 - Unused prototype objects from V8 FunctionTemplate initialization #20321

Closed
wants to merge 1 commit into from
Closed

Bug Fix for Issue #17668 - Unused prototype objects from V8 FunctionTemplate initialization #20321

wants to merge 1 commit into from

Commits on Apr 29, 2018

  1. src: removed unnecessary prototypes from Environment::SetProtoMethod 

    Added an optional parameter of type v8::ConstructorBehavior to
Environment::NewFunctionTemplate, defaulting to
v8::ConstructorBehavior::kAllow. Also modified
Environment::SetProtoMethod to pass
v8::ConstructorBehavior::kThrow to its
call to Environment::NewFunctionTemplate.

Fixes: nodejs#17668
Refs: nodejs#20321
    @brandontruggles
    brandontruggles committed Apr 29, 2018
    Configuration menu
    Copy the full SHA
    18108b4 View commit details
    Browse the repository at this point in the history