test: remove obsolete TODO comments for fs.readline() #2033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The readfile/pipe tests rely on pre-existing pipes in the system. This arguably tests the OS functionality and not really io.js functionality. Removing TODOs.
mscdex
added
fs
Trott
changed the title
|
LGTM |
Trott
added a commit
that referenced
this pull request
Jun 23, 2015
The readfile/pipe tests rely on pre-existing pipes in the system. This arguably tests the OS functionality and not really io.js functionality. Removing TODOs. PR-URL: #2033 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
|
Merged in 776a65e |
mscdex
pushed a commit
to mscdex/io.js
that referenced
this pull request
Jul 9, 2015
The readfile/pipe tests rely on pre-existing pipes in the system. This arguably tests the OS functionality and not really io.js functionality. Removing TODOs. PR-URL: nodejs#2033 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The readfile/pipe tests rely on a pre-existing pipe in the system (namely,
/dev/stdin). This does not exist on Windows.There doesn't seem to be an easy way (or perhaps any way?) to do all of:
STDIN...I tried a few creative-ish things (including abusing
net.createServer().listen()to trick Node into creating a named pipe and then trying to get cmd.exe to write to that pipe), but no dice.Here's the commit where this comment was initially introduced, if that helps: 1d3d02c
In the current code base, the line in
lib.fsthat is being changed is now https://github.com/nodejs/io.js/blob/5d2b846d1114bad5e7fbf04910ff59fc970c175e/lib/fs.js#L288Changing-1toposin that line does not result in the corresponding test failing, so it's not clear that the test is addressing the change in that commit anymore (if it ever did?).There is no reason to expect Windows to ever have this functionality.
So, in the interest of weed-whacking out all the TODOs in the tests, these should seemingly be removed. If there's consensus that this is wrong and it actually does capture useful information, perhaps it can be moved to the issue tracker rather than lurking in a code TODO.
Apologies in advance for another in a tedious series of TODO-removal PRs...