Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove console.table() as inspector-dependent #20346

Closed
wants to merge 1 commit into from
Closed

doc: remove console.table() as inspector-dependent #20346

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 26, 2018

console.table() is implemented in Node.js core and no longer requires
the inspector for use.

Checklist

@Trott
doc: remove console.table() as inspector-dependent
a5a9cc7 
`console.table()` is implemented in Node.js core and no longer requires
the inspector for use.
@nodejs-github-bot nodejs-github-bot added console Issues and PRs related to the console subsystem. doc Issues and PRs related to the documentations. labels Apr 26, 2018
@Trott Trott mentioned this pull request Apr 26, 2018
Closed
1 task
@Trott
Copy link
Member Author

Trott commented Apr 26, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/605/

@vsemozhetbyt vsemozhetbyt added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 26, 2018
@vsemozhetbyt
Copy link
Contributor

Please, add 👍 here to approve fast-tracking.

Trott added a commit to Trott/io.js that referenced this pull request Apr 27, 2018
@Trott
doc: remove console.table() as inspector-dependent
9c83956 
`console.table()` is implemented in Node.js core and no longer requires
the inspector for use.

PR-URL: nodejs#20346
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
@Trott
Copy link
Member Author

Trott commented Apr 27, 2018

Landed in 9c83956

@Trott Trott closed this Apr 27, 2018
MylesBorins pushed a commit that referenced this pull request May 4, 2018
@Trott @MylesBorins
doc: remove console.table() as inspector-dependent
cc09d7e 
`console.table()` is implemented in Node.js core and no longer requires
the inspector for use.

PR-URL: #20346
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
@MylesBorins MylesBorins mentioned this pull request May 8, 2018
Merged
@Trott Trott deleted the console-table-inspector branch January 13, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@richardlau richardlau richardlau approved these changes

@maclover7 maclover7 maclover7 approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. console Issues and PRs related to the console subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @vsemozhetbyt @TimothyGu @maclover7 @richardlau @nodejs-github-bot