Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove parenthetical in onboarding-extras #20393

Closed
wants to merge 1 commit into from
Closed

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 29, 2018

Remove "(I prefer the former)" from onboarding-extras. Without any
explanation as to why one might prefer A over B, it probably raises more
questions than it answers.

Checklist

Remove "(I prefer the former)" from onboarding-extras. Without any
explanation as to why one might prefer A over B, it probably raises more
questions than it answers.
@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 29, 2018
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 29, 2018
@Trott
Copy link
Member Author

Trott commented Apr 29, 2018

@Trott
Copy link
Member Author

Trott commented Apr 29, 2018

If you're a Collaborator and think this can be fast-tracked, please leave a 👍 on this comment. Thanks.

@BridgeAR
Copy link
Member

Independent from this PR: should we maybe document what the specific commands stand for that we ask to be executed?

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 29, 2018
@Trott
Copy link
Member Author

Trott commented Apr 29, 2018

Independent from this PR: should we maybe document what the specific commands stand for that we ask to be executed?

@BridgeAR Perhaps, although there is already a similar command in COLLABORATOR_GUIDE.md (a third variation to add to the two suggested here!) and the explanation should live there, not here, if an explanation is needed beyond the context. The entries in this doc should be removed or else incorporated into COLLABORATOR_GUIDE.md IMO.

@Trott
Copy link
Member Author

Trott commented Apr 29, 2018

Landed in 45c7e03

@Trott Trott closed this Apr 29, 2018
Trott added a commit to Trott/io.js that referenced this pull request Apr 29, 2018
Remove "(I prefer the former)" from onboarding-extras. Without any
explanation as to why one might prefer A over B, it probably raises more
questions than it answers.

PR-URL: nodejs#20393
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 4, 2018
Remove "(I prefer the former)" from onboarding-extras. Without any
explanation as to why one might prefer A over B, it probably raises more
questions than it answers.

PR-URL: #20393
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@MylesBorins MylesBorins mentioned this pull request May 8, 2018
@Trott Trott deleted the I branch January 13, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants