Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: remove unused using declarations node_http2 #20420

Closed
wants to merge 2 commits into from
Closed

http2: remove unused using declarations node_http2 #20420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25fbb85
http2: remove unused using declarations node_http2
danbev Apr 30, 2018
4ddc3d0
http2: remove unnecessary v8 qualified names
danbev Apr 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions src/node_http2.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ Http2Options::Http2Options(Environment* env) {
// a bit differently. For now, let's let nghttp2 take care of it.
nghttp2_option_set_builtin_recv_extension_type(options_, NGHTTP2_ALTSVC);

AliasedBuffer<uint32_t, v8::Uint32Array>& buffer =
AliasedBuffer<uint32_t, Uint32Array>& buffer =
env->http2_state()->options_buffer;
uint32_t flags = buffer[IDX_OPTIONS_FLAGS];

Expand Down Expand Up @@ -191,7 +191,7 @@ Http2Options::Http2Options(Environment* env) {
}

void Http2Session::Http2Settings::Init() {
AliasedBuffer<uint32_t, v8::Uint32Array>& buffer =
AliasedBuffer<uint32_t, Uint32Array>& buffer =
env()->http2_state()->settings_buffer;
uint32_t flags = buffer[IDX_SETTINGS_COUNT];

Expand Down Expand Up @@ -270,7 +270,7 @@ Local<Value> Http2Session::Http2Settings::Pack() {
void Http2Session::Http2Settings::Update(Environment* env,
Http2Session* session,
get_setting fn) {
AliasedBuffer<uint32_t, v8::Uint32Array>& buffer =
AliasedBuffer<uint32_t, Uint32Array>& buffer =
env->http2_state()->settings_buffer;
buffer[IDX_SETTINGS_HEADER_TABLE_SIZE] =
fn(**session, NGHTTP2_SETTINGS_HEADER_TABLE_SIZE);
Expand All @@ -288,7 +288,7 @@ void Http2Session::Http2Settings::Update(Environment* env,

// Initializes the shared TypedArray with the default settings values.
void Http2Session::Http2Settings::RefreshDefaults(Environment* env) {
AliasedBuffer<uint32_t, v8::Uint32Array>& buffer =
AliasedBuffer<uint32_t, Uint32Array>& buffer =
env->http2_state()->settings_buffer;

buffer[IDX_SETTINGS_HEADER_TABLE_SIZE] =
Expand Down Expand Up @@ -505,7 +505,7 @@ Http2Session::~Http2Session() {
}

inline bool HasHttp2Observer(Environment* env) {
AliasedBuffer<uint32_t, v8::Uint32Array>& observers =
AliasedBuffer<uint32_t, Uint32Array>& observers =
env->performance_state()->observers;
return observers[performance::NODE_PERFORMANCE_ENTRY_TYPE_HTTP2] != 0;
}
Expand All @@ -522,7 +522,7 @@ void Http2Stream::EmitStatistics() {
if (!HasHttp2Observer(env))
return;
HandleScope handle_scope(env->isolate());
AliasedBuffer<double, v8::Float64Array>& buffer =
AliasedBuffer<double, Float64Array>& buffer =
env->http2_state()->stream_stats_buffer;
buffer[IDX_STREAM_STATS_ID] = entry->id();
if (entry->first_byte() != 0) {
Expand Down Expand Up @@ -561,7 +561,7 @@ void Http2Session::EmitStatistics() {
if (!HasHttp2Observer(env))
return;
HandleScope handle_scope(env->isolate());
AliasedBuffer<double, v8::Float64Array>& buffer =
AliasedBuffer<double, Float64Array>& buffer =
env->http2_state()->session_stats_buffer;
buffer[IDX_SESSION_STATS_TYPE] = entry->type();
buffer[IDX_SESSION_STATS_PINGRTT] = entry->ping_rtt() / 1e6;
Expand Down Expand Up @@ -690,7 +690,7 @@ ssize_t Http2Session::OnCallbackPadding(size_t frameLen,
Local<Context> context = env()->context();
Context::Scope context_scope(context);

AliasedBuffer<uint32_t, v8::Uint32Array>& buffer =
AliasedBuffer<uint32_t, Uint32Array>& buffer =
env()->http2_state()->padding_buffer;
buffer[PADDING_BUF_FRAME_LENGTH] = frameLen;
buffer[PADDING_BUF_MAX_PAYLOAD_LENGTH] = maxPayloadLen;
Expand Down Expand Up @@ -2158,7 +2158,7 @@ void Http2Session::RefreshState(const FunctionCallbackInfo<Value>& args) {
ASSIGN_OR_RETURN_UNWRAP(&session, args.Holder());
DEBUG_HTTP2SESSION(session, "refreshing state");

AliasedBuffer<double, v8::Float64Array>& buffer =
AliasedBuffer<double, Float64Array>& buffer =
env->http2_state()->session_state_buffer;

nghttp2_session* s = **session;
Expand Down Expand Up @@ -2448,7 +2448,7 @@ void Http2Stream::RefreshState(const FunctionCallbackInfo<Value>& args) {

DEBUG_HTTP2STREAM(stream, "refreshing state");

AliasedBuffer<double, v8::Float64Array>& buffer =
AliasedBuffer<double, Float64Array>& buffer =
env->http2_state()->stream_state_buffer;

nghttp2_stream* str = **stream;
Expand Down
1 change: 0 additions & 1 deletion src/node_http2.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ namespace http2 {

using v8::Array;
using v8::Context;
using v8::EscapableHandleScope;
using v8::Isolate;
using v8::MaybeLocal;

Expand Down