Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: minor refactor to string_search.h #20546

Closed
wants to merge 1 commit into from
Closed

src: minor refactor to string_search.h #20546

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented May 5, 2018

  • Use std::max instead of a custom variant
  • Use member method pointers to avoid an extra layer of indirection
  • Stop transferring Vector into the node namespace
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@addaleax
src: minor refactor to string_search.h
1956677 
- Use `std::max` instead of a custom variant
- Use member method pointers to avoid an extra layer of indirection
- Stop transferring `Vector` into the `node` namespace
@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. labels May 5, 2018
@addaleax
Copy link
Member Author

addaleax commented May 5, 2018

CI: https://ci.nodejs.org/job/node-test-commit/18252/

@addaleax
Copy link
Member Author

addaleax commented May 5, 2018

FreeBSD re-run: https://ci.nodejs.org/job/node-test-commit-freebsd/17534/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 6, 2018
@addaleax
Copy link
Member Author

addaleax commented May 9, 2018

Landed in 9873875

@addaleax addaleax closed this May 9, 2018
@addaleax addaleax deleted the stringsearch-refactor branch May 9, 2018 16:18
addaleax added a commit that referenced this pull request May 9, 2018
@addaleax
src: minor refactor to string_search.h
9873875 
- Use `std::max` instead of a custom variant
- Use member method pointers to avoid an extra layer of indirection
- Stop transferring `Vector` into the `node` namespace

PR-URL: #20546
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
targos pushed a commit that referenced this pull request May 12, 2018
@addaleax @targos
src: minor refactor to string_search.h
5803973 
- Use `std::max` instead of a custom variant
- Use member method pointers to avoid an extra layer of indirection
- Stop transferring `Vector` into the `node` namespace

PR-URL: #20546
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
@addaleax addaleax mentioned this pull request May 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimothyGu TimothyGu TimothyGu approved these changes

@jasnell jasnell jasnell approved these changes

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@addaleax @danbev @jasnell @TimothyGu @nodejs-github-bot