Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: use macOS as operating system name #20579

Closed
wants to merge 1 commit into from
Closed

tools: use macOS as operating system name #20579

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented May 7, 2018

As of 2016, the operating system is macOS. Remove use of "macosx".

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@Trott
tools: use macOS as operating system name
ca89826 
As of 2016, the operating system is macOS. Remove use of "macosx".
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels May 7, 2018
@Trott
Copy link
Member Author

Trott commented May 7, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/682/

@Trott
Copy link
Member Author

Trott commented May 7, 2018

Full CI: https://ci.nodejs.org/job/node-test-pull-request/14703/

@vsemozhetbyt vsemozhetbyt added the macos Issues and PRs related to the macOS platform / OSX. label May 7, 2018
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 7, 2018
Trott added a commit to Trott/io.js that referenced this pull request May 10, 2018
@Trott
tools: use macOS as operating system name
f145a53 
As of 2016, the operating system is macOS. Remove use of "macosx".

PR-URL: nodejs#20579
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
Copy link
Member Author

Trott commented May 10, 2018

Landed in f145a53

@Trott Trott closed this May 10, 2018
targos pushed a commit that referenced this pull request May 12, 2018
@Trott @targos
tools: use macOS as operating system name
ebd102e 
As of 2016, the operating system is macOS. Remove use of "macosx".

PR-URL: #20579
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax addaleax mentioned this pull request May 14, 2018
Merged
@Trott Trott deleted the not-macosx branch January 13, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. macos Issues and PRs related to the macOS platform / OSX. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Trott @jasnell @lpinca @cjihrig @richardlau @trivikr @vsemozhetbyt @nodejs-github-bot