doc: fix nits in doc/api_assets/style.css #20601
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Merge rule sets for identical selectors. 2. Delete impossible selector block: we have only stability indexes 0, 1, and 2, so there can't be `.api_stability_3` class. Refs: nodejs.org/api/documentation.html#documentation_stability_index
vsemozhetbyt
added
the
fast-track
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
|
CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/687/ (just in case) |
jasnell
approved these changes
May 8, 2018
vsemozhetbyt
added
the
author ready
lpinca
approved these changes
May 8, 2018
maclover7
approved these changes
May 8, 2018
trivikr
approved these changes
May 9, 2018
tniessen
approved these changes
May 9, 2018
|
Landed in 8d3131b |
vsemozhetbyt
added a commit
that referenced
this pull request
May 10, 2018
1. Merge rule sets for identical selectors. 2. Delete impossible selector block: we have only stability indexes 0, 1, and 2, so there can't be `.api_stability_3` class. Refs: nodejs.org/api/documentation.html#documentation_stability_index PR-URL: #20601 Refs: https://nodejs.org/api/documentation.html#documentation_stability_index Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos
pushed a commit
that referenced
this pull request
May 12, 2018
1. Merge rule sets for identical selectors. 2. Delete impossible selector block: we have only stability indexes 0, 1, and 2, so there can't be `.api_stability_3` class. Refs: nodejs.org/api/documentation.html#documentation_stability_index PR-URL: #20601 Refs: https://nodejs.org/api/documentation.html#documentation_stability_index Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesMerge rule sets for identical selectors.
Delete impossible selector block: we have only stability indexes 0, 1, and 2, so there can't be
.api_stability_3class. Refs: documentation.html#documentation_stability_indexI suspect we have some other outdated unused selectors in this file, but I've ventured to change only these safe cases as I am not very aware of frontend things. Maybe this can be a small task for code-and-learn with frontend folks? Say, all selectors may be checked against https://nodejs.org/api/all.html (or its last nightly variant) with
document.querySelectorAll('selector')in DevTools.