-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible to build iojs with ninja #2065
Conversation
It is currently possible to build io.js with ninja (I do it all the time), but make will still do some steps if you run it, which is a little annoying for things like I have an alias set up to do: @yury-s does this fix that issue where make will still do extra build stuff if you run it, or? |
@Fishrock123 which platform are you on (I suspect it may work on Mac because of different toolset used there, did't have chance to check)? The command line you specified fails for me on linux. ninja -C out/Release fails with tons of 'multiple symbol definition' errors: btw, the gyp patch I mentioned has landed in the gyp repository. I'm not sure how often iojs' copy of gyp is updated though. |
#2074 - it was about time we upgraded again anyway. |
Update GYP to HEAD, omit the docs/ and test/ directories. Fixes: nodejs#2065
Ah, possibly, yes. I use Ninja 1.5.3 on OS X 10.10.3 |
Includes improved support for VS 2015[0] and makes it possible to build with ninja again[1]. [0] https://codereview.chromium.org/1112753003 [1] https://codereview.chromium.org/1209553002 Fixes: nodejs#2065 PR-URL: nodejs#2074 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>
Fixed by 99cbbc0. |
Includes improved support for VS 2015[0] and makes it possible to build with ninja again[1]. [0] https://codereview.chromium.org/1112753003 [1] https://codereview.chromium.org/1209553002 Fixes: nodejs#2065 PR-URL: nodejs#2074 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>
This change fixes link-time error when building iojs with ninja instead of make. The following commands now work fine:
$ ./tools/gyp_node.gyp -f ninja
$ ninja -C out/Release iojs -j100
The patch is going to be merged into gyp (https://codereview.chromium.org/1209553002/). The more details about why this change is necessary can be found in the mentioned codereview.