Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: plug AliasedBuffer cctest memory leak #20665

Closed
wants to merge 2 commits into from
Closed

test: plug AliasedBuffer cctest memory leak #20665

wants to merge 2 commits into from

Conversation

addaleax
Copy link
Member

No need to heap-allocate values here.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@addaleax
test: plug AliasedBuffer cctest memory leak
465d9f2 
No need to heap-allocate values here.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label May 10, 2018
@addaleax
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-commit/18394/

@addaleax addaleax added the c++ Issues and PRs that require attention from people who are familiar with C++. label May 10, 2018
@bnoordhuis
Copy link
Member

Neither the linter nor cl.exe seems to like VLAs.

Not a fan myself for that matter, I'd use std::vector. :-)

@addaleax
Copy link
Member Author

@bnoordhuis Yup, done (but switched throughout the file, not just where the original change was).

CI: https://ci.nodejs.org/job/node-test-commit/18395/

@addaleax
Copy link
Member Author

Linux CI re-run: https://ci.nodejs.org/job/node-test-commit-linux/18666/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 11, 2018
jasnell pushed a commit that referenced this pull request May 12, 2018
@addaleax @jasnell
test: plug AliasedBuffer cctest memory leak
19c9ff5 
No need to heap-allocate values here.

PR-URL: #20665
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@jasnell
Copy link
Member

jasnell commented May 12, 2018

Landed in 19c9ff5

@jasnell jasnell closed this May 12, 2018
addaleax added a commit that referenced this pull request May 14, 2018
@addaleax
test: plug AliasedBuffer cctest memory leak
87f3f5a 
No need to heap-allocate values here.

PR-URL: #20665
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@addaleax addaleax mentioned this pull request May 14, 2018
Merged
addaleax added a commit that referenced this pull request Jun 29, 2018
@addaleax
test: plug AliasedBuffer cctest memory leak
909524c 
No need to heap-allocate values here.

PR-URL: #20665
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 9, 2018
Merged
rvagg pushed a commit that referenced this pull request Aug 16, 2018
@addaleax @rvagg
test: plug AliasedBuffer cctest memory leak
71ee19e 
No need to heap-allocate values here.

PR-URL: #20665
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

@danbev danbev danbev approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@addaleax @bnoordhuis @jasnell @danbev @cjihrig @nodejs-github-bot