Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module: introduce defaultModuleName in module.js #20709

Closed
wants to merge 1 commit into from
Closed

module: introduce defaultModuleName in module.js #20709

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented May 14, 2018

This commit adds a constant named defaultModuleName to avoid duplicating
it in the Module constructor function.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@danbev
module: introduce defaultModuleName in module.js
1420d29 
This commit adds a constant named defaultModuleName to avoid duplicating
it in the Module constructor function.
@nodejs-github-bot nodejs-github-bot added the vm Issues and PRs related to the vm subsystem. label May 14, 2018
@danbev
Copy link
Contributor Author

danbev commented May 14, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/14856/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 14, 2018
@danbev
Copy link
Contributor Author

danbev commented May 16, 2018

Landed in ea01d30.

@danbev danbev closed this May 16, 2018
@danbev danbev deleted the module_js_default_module_name branch May 16, 2018 06:11
danbev added a commit that referenced this pull request May 16, 2018
@danbev
module: introduce defaultModuleName in module.js
ea01d30 
This commit adds a constant named defaultModuleName to avoid duplicating
it in the Module constructor function.

PR-URL: #20709
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 22, 2018
@danbev @MylesBorins
module: introduce defaultModuleName in module.js
678b754 
This commit adds a constant named defaultModuleName to avoid duplicating
it in the Module constructor function.

PR-URL: #20709
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax addaleax mentioned this pull request May 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@devsnek devsnek devsnek approved these changes

@hiroppy hiroppy hiroppy approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@danbev @jasnell @hiroppy @devsnek @trivikr @BridgeAR @nodejs-github-bot