Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update eslint and re-enable comma-spacing rule #2072

Closed
wants to merge 2 commits into from

Conversation

silverwind
Copy link
Contributor

Notably, eslint/eslint#2408 has been fixed, and I re-enabled the comma-spacing rule because of it. Ideally, the test changes should have been part of #1721, but it slipped past me because the rule was effectively disabled.

The rule was disabled because of an eslint bug which is now resolved.
All code in lib was already conforming and only test code needed a few
changes to make the linter happy with this rule enabled.

Ref: eslint/eslint#2408
@cjihrig
Copy link
Contributor

cjihrig commented Jun 28, 2015

LGTM

2 similar comments
@yosuke-furukawa
Copy link
Member

LGTM

@rlidwka
Copy link
Contributor

rlidwka commented Jun 29, 2015

LGTM

silverwind added a commit that referenced this pull request Jun 29, 2015
PR-URL: #2072
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Reviewed-by: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Alex Kocharin <alex@kocharin.ru>
silverwind added a commit that referenced this pull request Jun 29, 2015
The rule was disabled because of an eslint bug which is now resolved.
All code in lib was already conforming and only test code needed a few
changes to make the linter happy with this rule enabled.

Ref: eslint/eslint#2408

PR-URL: #2072
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Reviewed-by: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Alex Kocharin <alex@kocharin.ru>
@silverwind
Copy link
Contributor Author

Thanks, landed in d91e10b and e3f9335.

@silverwind silverwind closed this Jun 29, 2015
@rvagg rvagg mentioned this pull request Jun 30, 2015
mscdex pushed a commit to mscdex/io.js that referenced this pull request Jul 9, 2015
PR-URL: nodejs#2072
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Reviewed-by: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Alex Kocharin <alex@kocharin.ru>
mscdex pushed a commit to mscdex/io.js that referenced this pull request Jul 9, 2015
The rule was disabled because of an eslint bug which is now resolved.
All code in lib was already conforming and only test code needed a few
changes to make the linter happy with this rule enabled.

Ref: eslint/eslint#2408

PR-URL: nodejs#2072
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Reviewed-by: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Alex Kocharin <alex@kocharin.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants