assert: fix wrong message indentation #20791
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
assert
jasnell
approved these changes
May 16, 2018
trivikr
approved these changes
May 17, 2018
BridgeAR
added
the
author ready
XadillaX
approved these changes
May 18, 2018
BridgeAR
added
wip
BridgeAR
force-pushed
the
indent-assertion-error
branch
from
4192fc0
to
ce2ae3b
Compare
If code is read from a file and that code is indented, it would be misaligned. This makes sure it has a natural indentation that is relative to the starting point of the assertion.
BridgeAR
force-pushed
the
indent-assertion-error
branch
from
ce2ae3b
to
7eb70a9
Compare
|
Rebased due to conflicts. I also fixed another case that resulted in weird indentation. Now it just always normalizes the output. So PTAL. New CI https://ci.nodejs.org/job/node-test-pull-request/14995/ |
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
May 21, 2018
If code is read from a file and that code is indented, it would be misaligned. This makes sure it has a natural indentation that is relative to the starting point of the assertion. PR-URL: nodejs#20791 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
|
Thanks. Landed in 9c2e67b 🎉 |
MylesBorins
pushed a commit
that referenced
this pull request
May 22, 2018
If code is read from a file and that code is indented, it would be misaligned. This makes sure it has a natural indentation that is relative to the starting point of the assertion. PR-URL: #20791 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
May 23, 2018
If code is read from a file and that code is indented, it would be misaligned. This makes sure it has a natural indentation that is relative to the starting point of the assertion. PR-URL: #20791 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If code is read from a file and that code is indented, it would be
misaligned. This makes sure it has a natural indentation that is
relative to the starting point of the assertion.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes