repl: always show all error properties #20801
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently errors only show the error stack. This changes it to inspect the full error instead of just using the stack.
jasnell
approved these changes
May 17, 2018
BridgeAR
added
the
author ready
|
I personally think this is a semver-patch. @nodejs/tsc PTAL |
addaleax
approved these changes
May 17, 2018
jdalton
reviewed
May 18, 2018
| const timeout = setTimeout(() => { | ||
| reject( | ||
| new Error(`Repl did not reply as expected for:\n\n${inspect(expected)}`) | ||
| ); |
There was a problem hiding this comment.
Is expected always an event name (a string?).
If it is I think padding with two newlines is a bit much. It could just go right after the : .
There was a problem hiding this comment.
No, expected is the expected output, so either a string or an array with many strings.
jdalton
reviewed
May 18, 2018
| }, 500); | ||
| ee.once('data', common.mustCall((...args) => { | ||
| clearTimeout(timeout); | ||
| resolve(...args); |
There was a problem hiding this comment.
With promises I believe once resolve is called a reject will have no effect so it could go without clearing since the timeout has no other side effects.
There was a problem hiding this comment.
But it would keep the test alive after being done if I am not mistaken.
trivikr
approved these changes
May 20, 2018
|
Update: Closed by mistake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently errors only show the error stack. This changes it to
inspect the full error instead of just using the stack.
Refs: #20253
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes