Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v8.x] http2: pass session to DEBUG_HTTP2SESSION2 #20815

Closed
wants to merge 1 commit into from

Commits on May 18, 2018

  1. http2: pass session to DEBUG_HTTP2SESSION2

    When configure with --debug-http2 --debug-nghttp2 the following
    compilation error is generated:
    
    DEBUG_HTTP2SESSION2(this, "fatal error receiving data: %d", ret);
                              ^
    ../src/node_http2.cc:1690:27:
    error: invalid use of 'this' outside of a non-static member function
    
    1 errors generated.
    
    OnStreamReadImpl is static and I think the intention was to pass in the
    session variable here.
    
    Refs: nodejs#20806
    danbev committed May 18, 2018
    Configuration menu
    Copy the full SHA
    a8dc0da View commit details
    Browse the repository at this point in the history