doc: fix fs.promises sample codes. #20838
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
benjamingr
approved these changes
May 19, 2018
Member
benjamingr
left a comment
benjamingr
left a comment
There was a problem hiding this comment.
Thank you for doing this! Changes LGTM
Member
ghost
reviewed
May 19, 2018
| ```js | ||
| const fs = require('fs'); | ||
| const fsPromises = require('fs').promises; | ||
| const { COPYFILE_EXCL } = fs.constants; |
vsemozhetbyt
approved these changes
May 19, 2018
Contributor
vsemozhetbyt
left a comment
vsemozhetbyt
left a comment
There was a problem hiding this comment.
LGTM with @Ehstrali's comment addressed.
Thank you!
vsemozhetbyt
added
the
fast-track
Contributor
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
Contributor
trivikr
approved these changes
May 20, 2018
trivikr
added
the
author ready
Contributor
|
Landed in 7295d3b |
vsemozhetbyt
pushed a commit
that referenced
this pull request
May 20, 2018
PR-URL: #20838 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 22, 2018
PR-URL: #20838 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Recreated the same PR from #20805
Fix fs.promises sample codes in doc/api/fs.md .
Please review this.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes