Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove TimerWrap #20894

Closed
wants to merge 9 commits into from
Closed

src: remove TimerWrap #20894

wants to merge 9 commits into from

Commits on Jun 6, 2018

  1. test: remove outdated, non-functioning test 

    The timers directory test, utilizing FakeTime, has not worked in
quite a while and is not truly testing Node.js behaviour. If a
similar test is necessary it would be better suited to libuv
on which Node.js relies for timers functionality.
    @apapirovski
    apapirovski committed Jun 6, 2018
    Configuration menu
    Copy the full SHA
    32fb3ac View commit details
    Browse the repository at this point in the history

  2. src: refactor timers to remove TimerWrap 

    Refactor Timers to behave more similarly to Immediates by having
a single uv_timer_t handle which is stored on the Environment.

No longer expose timers in a public binding and instead make
it part of the internalBinding.
    @apapirovski
    apapirovski committed Jun 6, 2018
    Configuration menu
    Copy the full SHA
    70ecef8 View commit details
    Browse the repository at this point in the history

  3. src: remove tick_info->has_thrown 

    This is no longer necessary in the only place it was used (timers).
    @apapirovski
    apapirovski committed Jun 6, 2018
    Configuration menu
    Copy the full SHA
    46d8333 View commit details
    Browse the repository at this point in the history

  4. fixup: addaleax feedback

    @apapirovski
    apapirovski committed Jun 6, 2018
    Configuration menu
    Copy the full SHA
    347def5 View commit details
    Browse the repository at this point in the history

  5. fixup: bnoordhuis feedback

    @apapirovski
    apapirovski committed Jun 6, 2018
    Configuration menu
    Copy the full SHA
    0269378 View commit details
    Browse the repository at this point in the history

  6. fixup: add can_call_into_js

    @apapirovski
    apapirovski committed Jun 6, 2018
    Configuration menu
    Copy the full SHA
    8cf7d75 View commit details
    Browse the repository at this point in the history

  7. fixup: fishrock123 feedbback

    @apapirovski
    apapirovski committed Jun 6, 2018
    Configuration menu
    Copy the full SHA
    f057f2a View commit details
    Browse the repository at this point in the history

  8. fixup: addaleax feedback

    @apapirovski
    apapirovski committed Jun 6, 2018
    Configuration menu
    Copy the full SHA
    a28a457 View commit details
    Browse the repository at this point in the history

  9. fixup: remove obsolete license

    @apapirovski
    apapirovski committed Jun 6, 2018
    Configuration menu
    Copy the full SHA
    bb1dafb View commit details
    Browse the repository at this point in the history