v10.2.1 proposal #20943
Merged
v10.2.1 proposal #20943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test-zlib.zlib-binding.deflate is failing continuously in our CI, leaving us with 1% successful builds during the last 100 runs. This commit marks the test as flaky while the issue is not resolved. Ref: #20907 PR-URL: #20935 Refs: #20907 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Alternative to #20938 (clean revert) and #20925 (adding the headers to the release tarball). The changes to `src/node.h` are a clean revert in the same ways as #20938 does it, the difference being that the new `.cc` files are kept here. This has the advantage of not being another large diff that other PRs will have to rebase against, especially since the split into `callback_scope.cc` and `exceptions.cc` is something that we want to keep in the long run. This essentialy implements bnoordhuis’s suggestion from #20925. PR-URL: #20939 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Refael Ackermann <refack@gmail.com>
PR-URL: #20941 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
nodejs-github-bot
added
c++
|
A.k.a The Ooops-We-Broke-The-Planet Release |
jasnell
approved these changes
May 24, 2018
targos
approved these changes
May 24, 2018
|
|
This is a follow up release to fix two regressions that were introduced in v10.2.0. PR-URL: #20943
richardlau
approved these changes
May 24, 2018
MylesBorins
force-pushed
the
v10.2.1-proposal
branch
from
a486909 to
65d13be
Compare
|
failures in CI are known flakes and infra... manually testing that native modules are working again. Promoting the release |
MylesBorins
added a commit
that referenced
this pull request
May 24, 2018
This is a follow up release to fix two regressions that were introduced in v10.2.0. PR-URL: #20943
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2018-05-24, Version 10.2.1 (Current), @MylesBorins
Notable Changes
This is a follow up release to fix two regressions that were introduced in v10.2.0.
Commits
2a9c83321b] - http: fix res emit close before user finish (Robert Nagy) #209410b1ba20fc0] - src: re-integrate headers into node.h (Anna Henningsen) #2093952f21fbfbc] - test: mark test-zlib.zlib-binding.deflate as flaky (Matheus Marchini) #20935