test: removed message from strictEqual #20983
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By removing the message from strictEqual, it will now print out the actual values of a and b, which will be more helpful in debugging. The old message has been added as a comment above the test.
BridgeAR
approved these changes
May 26, 2018
richardlau
approved these changes
May 26, 2018
trivikr
approved these changes
May 26, 2018
trivikr
added
the
author ready
Trott
approved these changes
May 27, 2018
benjamingr
approved these changes
May 27, 2018
cjihrig
approved these changes
May 27, 2018
lpinca
approved these changes
May 27, 2018
jasnell
approved these changes
May 29, 2018
|
Re-running Linux CI: https://ci.nodejs.org/job/node-test-commit-linux/19207/ Re-running Windows CI: https://ci.nodejs.org/job/node-test-commit-windows-fanned/18399/ |
|
landed in b23f8ee |
apapirovski
pushed a commit
that referenced
this pull request
Jun 1, 2018
By removing the message from strictEqual, it will now print out the actual values of a and b, which will be more helpful in debugging. The old message has been added as a comment above the test. PR-URL: #20983 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jun 6, 2018
By removing the message from strictEqual, it will now print out the actual values of a and b, which will be more helpful in debugging. The old message has been added as a comment above the test. PR-URL: #20983 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By removing the message from strictEqual, it will now print out the
actual values of a and b, which will be more helpful in debugging. The
old message has been added as a comment above the test.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes