Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add source for test.wasm #21082

Closed
wants to merge 1 commit into from
Closed

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Jun 1, 2018

The original commit 74e7a4a
("test: add basic WebAssembly test") references the source for
test.wasm and while there are tools to go from wasm to wat but
having the source viewable is helpful I think.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

The original commit 74e7a4a
("test: add basic WebAssembly test") references the source for
test.wasm and while there are tools to go from wasm to wat but
having the source viewable is helpful I think.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jun 1, 2018
@danbev
Copy link
Contributor Author

danbev commented Jun 1, 2018

@nodejs nodejs deleted a comment from refack Jun 1, 2018
@danbev
Copy link
Contributor Author

danbev commented Jun 4, 2018

node-test-commit-linux failure looks unrelated

console output:

ora-latest-x64/out/Debug/obj.host/icutools/deps/icu-small/source/common/rbbirb.o.d: Permission denied
09:46:30 warning: failed to remove out/Debug/.deps/home/iojs/build/workspace/node-test-commit-linux/nodes/fedora-latest-x64/out/Debug/obj.host/icutools/deps/icu-small/source/common/locmap.o.d: Permission denied
09:46:30 warning: failed to remove out/Debug/.deps/home/iojs/build/workspace/node-test-commit-li

@apapirovski
Copy link
Member

I think it might be infra related? @nodejs/build? @Trott?

@danbev
Copy link
Contributor Author

danbev commented Jun 4, 2018

Landed in 898609e.

@danbev danbev closed this Jun 4, 2018
danbev added a commit that referenced this pull request Jun 4, 2018
The original commit 74e7a4a
("test: add basic WebAssembly test") references the source for
test.wasm and while there are tools to go from wasm to wat but
having the source viewable is helpful I think.

PR-URL: #21082
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jun 6, 2018
The original commit 74e7a4a
("test: add basic WebAssembly test") references the source for
test.wasm and while there are tools to go from wasm to wat but
having the source viewable is helpful I think.

PR-URL: #21082
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants