Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: fix "comparisons"' typo #21085

Closed
wants to merge 1 commit into from
Closed

benchmark: fix "comparisons"' typo #21085

wants to merge 1 commit into from

Conversation

hiroppy
Copy link
Member

@hiroppy hiroppy commented Jun 1, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@hiroppy hiroppy added the benchmark Issues and PRs related to the benchmark subsystem. label Jun 1, 2018
@benjamingr
Copy link
Member

Collaborators please +1 to support fast-tracking this PR.

@benjamingr benjamingr added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 1, 2018
@Trott
Copy link
Member

Trott commented Jun 1, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/782/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 1, 2018
@nodejs nodejs deleted a comment from refack Jun 1, 2018
hiroppy added a commit that referenced this pull request Jun 1, 2018
@hiroppy
benchmark: fix "comparisons"' typo
923f6ac 
PR-URL: #21085
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@hiroppy
Copy link
Member Author

hiroppy commented Jun 1, 2018

Landed in 923f6ac.

@hiroppy hiroppy closed this Jun 1, 2018
@hiroppy hiroppy deleted the feature/fix-typo branch June 1, 2018 23:09
MylesBorins pushed a commit that referenced this pull request Jun 6, 2018
@hiroppy @MylesBorins
benchmark: fix "comparisons"' typo
be249d9 
PR-URL: #21085
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Jun 6, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance lance lance approved these changes

@Trott Trott Trott approved these changes

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. benchmark Issues and PRs related to the benchmark subsystem. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hiroppy @benjamingr @Trott @lance @lpinca @richardlau