Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: unmark test as flaky #21109

Closed
wants to merge 1 commit into from
Closed

test: unmark test as flaky #21109

wants to merge 1 commit into from

Conversation

apapirovski
Copy link
Member

This test is no longer flaky as of #21077.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@apapirovski apapirovski requested a review from Trott June 3, 2018 11:21
@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. test Issues and PRs related to the tests. labels Jun 3, 2018
@apapirovski
Copy link
Member Author

Please 👍 if you approve fast-tracking.

@apapirovski
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/15240/

@addaleax addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 3, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Jun 3, 2018
@apapirovski @Trott
test: unmark test-zlib.zlib-binding.deflate flaky
d528781 
PR-URL: nodejs#21109
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott
Copy link
Member

Trott commented Jun 3, 2018

Landed in d528781

@Trott Trott closed this Jun 3, 2018
@apapirovski apapirovski deleted the patch-async-hooks-remove-flaky-test branch June 3, 2018 14:23
MylesBorins pushed a commit that referenced this pull request Jun 6, 2018
@apapirovski @MylesBorins
test: unmark test-zlib.zlib-binding.deflate flaky
8e3e18e 
PR-URL: #21109
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jun 6, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
async_hooks Issues and PRs related to the async hooks subsystem. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@apapirovski @Trott @addaleax @tniessen @nodejs-github-bot