Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update buffer doc with swap16() note to indicate big endian #21111

Closed
wants to merge 1 commit into from
Closed

doc: update buffer doc with swap16() note to indicate big endian #21111

wants to merge 1 commit into from

Conversation

BeniCheni
Copy link
Contributor

This simple doc update PR attempts to resolve #12813. If the PR is incorrect, happy to update under advice, or I can close the PR if it's irrelevant. Thanks.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. labels Jun 3, 2018
@mscdex
Copy link
Contributor

mscdex commented Jun 3, 2018

These methods don't really have anything to do with endianness. The issue you linked to is about text encodings, which is a separate matter.

@BeniCheni
Copy link
Contributor Author

Okay, thanks. Let me close the PR and understand better.

@BeniCheni BeniCheni closed this Jun 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document how to get swap endian for the Buffer class
3 participants