Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v8: replace Buffer with FastBuffer in deserialize #21196

Closed
wants to merge 4 commits into from
Closed

v8: replace Buffer with FastBuffer in deserialize #21196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b072d74
v8: replace Buffer with FastBuffer in deserialize
ryzokuken Jun 7, 2018
84414b2
fixup! v8: replace Buffer with FastBuffer in deserialize
ryzokuken Jun 7, 2018
c98b7b1
fixup! v8: replace Buffer with FastBuffer in deserialize
ryzokuken Jun 8, 2018
7e39fd1
fixup! v8: replace Buffer with FastBuffer in deserialize
ryzokuken Jun 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/v8.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ const arrayBufferViewTypeToIndex = new Map();
}
}

const bufferConstructorIndex = arrayBufferViewTypes.push(Buffer) - 1;
const bufferConstructorIndex = arrayBufferViewTypes.push(FastBuffer) - 1;

class DefaultSerializer extends Serializer {
constructor() {
Expand Down
8 changes: 8 additions & 0 deletions test/parallel/test-v8-deserialize-buffer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
// Flags: --pending-deprecation --no-warnings
'use strict';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a Flags: --pending-deprecations?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add one, gimme a sec.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, most other tests add --no-warnings too, but doesn't that kinda defeat the purpose of the test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example:

// Flags: --pending-deprecation --no-warnings
'use strict';

const common = require('../common');

process.on('warning', common.mustNotCall());

Buffer.of(0, 1);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it doesn't, the test fails with no warnings getting printed out, exactly like it should. Adding the line.


const common = require('../common');
const v8 = require('v8');

process.on('warning', common.mustNotCall());
v8.deserialize(v8.serialize(Buffer.alloc(0)));