Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactoring test-repl-tab-complete with common.mustCall #2122

Closed
wants to merge 1 commit into from
Closed

test: refactoring test-repl-tab-complete with common.mustCall #2122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 37 additions & 47 deletions test/parallel/test-repl-tab-complete.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,17 @@ var assert = require('assert');
var util = require('util');
var repl = require('repl');
var referenceErrors = 0;
var completionCount = 0;
var expectedReferenceErrors = 0;

function doNotCall() {
assert(false);
function getDoNotCallFunction() {
expectedReferenceErrors += 1;
return function() {
assert(false);
};
}

process.on('exit', function() {
assert.strictEqual(referenceErrors, 6);
assert.strictEqual(completionCount, 12);
assert.strictEqual(referenceErrors, expectedReferenceErrors);
});

// A stream to push an array into a REPL
Expand Down Expand Up @@ -51,19 +53,17 @@ putIn.run([
'var inner = {',
'one:1'
]);
testMe.complete('inner.o', doNotCall);
testMe.complete('inner.o', getDoNotCallFunction());

testMe.complete('console.lo', function(error, data) {
completionCount++;
testMe.complete('console.lo', common.mustCall(function(error, data) {
assert.deepEqual(data, [['console.log'], 'console.lo']);
});
}));

// Tab Complete will return globaly scoped variables
putIn.run(['};']);
testMe.complete('inner.o', function(error, data) {
completionCount++;
testMe.complete('inner.o', common.mustCall(function(error, data) {
assert.deepEqual(data, works);
});
}));

putIn.run(['.clear']);

Expand All @@ -73,7 +73,7 @@ putIn.run([
'?',
'{one: 1} : '
]);
testMe.complete('inner.o', doNotCall);
testMe.complete('inner.o', getDoNotCallFunction());

putIn.run(['.clear']);

Expand All @@ -82,15 +82,14 @@ putIn.run([
'var top = function() {',
'var inner = {one:1};'
]);
testMe.complete('inner.o', function(error, data) {
completionCount++;
testMe.complete('inner.o', common.mustCall(function(error, data) {
assert.deepEqual(data, works);
});
}));

// When you close the function scope tab complete will not return the
// locally scoped variable
putIn.run(['};']);
testMe.complete('inner.o', doNotCall);
testMe.complete('inner.o', getDoNotCallFunction());

putIn.run(['.clear']);

Expand All @@ -101,10 +100,9 @@ putIn.run([
' one:1',
'};'
]);
testMe.complete('inner.o', function(error, data) {
completionCount++;
testMe.complete('inner.o', common.mustCall(function(error, data) {
assert.deepEqual(data, works);
});
}));

putIn.run(['.clear']);

Expand All @@ -116,10 +114,9 @@ putIn.run([
' one:1',
'};'
]);
testMe.complete('inner.o', function(error, data) {
completionCount++;
testMe.complete('inner.o', common.mustCall(function(error, data) {
assert.deepEqual(data, works);
});
}));

putIn.run(['.clear']);

Expand All @@ -132,10 +129,9 @@ putIn.run([
' one:1',
'};'
]);
testMe.complete('inner.o', function(error, data) {
completionCount++;
testMe.complete('inner.o', common.mustCall(function(error, data) {
assert.deepEqual(data, works);
});
}));

putIn.run(['.clear']);

Expand All @@ -148,7 +144,7 @@ putIn.run([
' one:1',
'};'
]);
testMe.complete('inner.o', doNotCall);
testMe.complete('inner.o', getDoNotCallFunction());

putIn.run(['.clear']);

Expand All @@ -161,7 +157,7 @@ putIn.run([
' one:1',
'};'
]);
testMe.complete('inner.o', doNotCall);
testMe.complete('inner.o', getDoNotCallFunction());

putIn.run(['.clear']);

Expand All @@ -175,18 +171,17 @@ putIn.run([
' one:1',
'};'
]);
testMe.complete('inner.o', doNotCall);
testMe.complete('inner.o', getDoNotCallFunction());

putIn.run(['.clear']);

// make sure tab completion works on non-Objects
putIn.run([
'var str = "test";'
]);
testMe.complete('str.len', function(error, data) {
completionCount++;
testMe.complete('str.len', common.mustCall(function(error, data) {
assert.deepEqual(data, [['str.length'], 'str.len']);
});
}));

putIn.run(['.clear']);

Expand All @@ -195,32 +190,28 @@ var spaceTimeout = setTimeout(function() {
throw new Error('timeout');
}, 1000);

testMe.complete(' ', function(error, data) {
completionCount++;
testMe.complete(' ', common.mustCall(function(error, data) {
assert.deepEqual(data, [[], undefined]);
clearTimeout(spaceTimeout);
});
}));

// tab completion should pick up the global "toString" object, and
// any other properties up the "global" object's prototype chain
testMe.complete('toSt', function(error, data) {
completionCount++;
testMe.complete('toSt', common.mustCall(function(error, data) {
assert.deepEqual(data, [['toString'], 'toSt']);
});
}));

// Tab complete provides built in libs for require()
putIn.run(['.clear']);

testMe.complete('require(\'', function(error, data) {
completionCount++;
testMe.complete('require(\'', common.mustCall(function(error, data) {
assert.strictEqual(error, null);
repl._builtinLibs.forEach(function(lib) {
assert.notStrictEqual(data[0].indexOf(lib), -1, lib + ' not found');
});
});
}));

testMe.complete('require(\'n', function(error, data) {
completionCount++;
testMe.complete('require(\'n', common.mustCall(function(error, data) {
assert.strictEqual(error, null);
assert.strictEqual(data.length, 2);
assert.strictEqual(data[1], 'n');
Expand All @@ -230,15 +221,14 @@ testMe.complete('require(\'n', function(error, data) {
if (completion)
assert(/^n/.test(completion));
});
});
}));

// Make sure tab completion works on context properties
putIn.run(['.clear']);

putIn.run([
'var custom = "test";'
]);
testMe.complete('cus', function(error, data) {
completionCount++;
testMe.complete('cus', common.mustCall(function(error, data) {
assert.deepEqual(data, [['custom'], 'cus']);
});
}));