Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win, build: fix building on 32-bit machines #21437

Closed
wants to merge 1 commit into from
Closed

win, build: fix building on 32-bit machines #21437

wants to merge 1 commit into from

Conversation

bzoz
Copy link
Contributor

@bzoz bzoz commented Jun 21, 2018

Fixes: #21402

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

/cc @nodejs/build-files @nodejs/platform-windows

@nodejs-github-bot
Copy link
Collaborator

@bzoz build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/110/pipeline

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. labels Jun 21, 2018
@bzoz
Copy link
Contributor Author

bzoz commented Jun 21, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/15549/

@refack refack mentioned this pull request Jun 21, 2018
Merged
3 tasks
@BridgeAR BridgeAR added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jun 21, 2018
@ghost ghost mentioned this pull request Jun 22, 2018
Closed
@targos
Copy link
Member

targos commented Jun 24, 2018

Resumed CI: https://ci.nodejs.org/job/node-test-pull-request/15581/

@apapirovski
Copy link
Member

Landed in 43a2091

apapirovski pushed a commit that referenced this pull request Jun 25, 2018
@bzoz @apapirovski
win, build: fix building on 32-bit machines
43a2091 
Fixes: #21402

PR-URL: #21437
Fixes: #21402
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Jun 25, 2018
@bzoz @targos
win, build: fix building on 32-bit machines
ba8ee17 
Fixes: #21402

PR-URL: #21437
Fixes: #21402
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targos targos mentioned this pull request Jul 3, 2018
Merged
refack added a commit to refack/node that referenced this pull request Aug 16, 2018
@refack
doc: Windows building supported on x64
73b8dde 
Since we are CI testing on x64 hosts, we can only commit to x64 hosts.

PR-URL: nodejs#21443
Refs: nodejs#21402
Refs: nodejs#21437
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: João Reis <reis@janeasystems.com>
targos pushed a commit that referenced this pull request Aug 19, 2018
@refack @targos
doc: Windows building supported on x64
474eda6 
Since we are CI testing on x64 hosts, we can only commit to x64 hosts.

PR-URL: #21443
Refs: #21402
Refs: #21437
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: João Reis <reis@janeasystems.com>
targos pushed a commit that referenced this pull request Sep 3, 2018
@refack @targos
doc: Windows building supported on x64
c894145 
Since we are CI testing on x64 hosts, we can only commit to x64 hosts.

PR-URL: #21443
Refs: #21402
Refs: #21437
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: João Reis <reis@janeasystems.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot build on Win 8.1 (x86)
9 participants
@bzoz @nodejs-github-bot @targos @apapirovski @refack @jasnell @addaleax @richardlau @BridgeAR