-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: upgrade npm to 2.13.0 #2152
Conversation
Every npm version bump requires a few patches to be floated on node-gyp for io.js compatibility. These patches are found in 03d1992, 5de334c, and da730c7. This commit squashes them into a single commit. PR-URL: nodejs#990 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
The delay-load hook allows node.exe/iojs.exe to be renamed. See efadffe for more background. PR-URL: nodejs#1433 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@othiym23 that patch lives on |
@thefourtheye due to how npm releases are done, review comments left here are pretty fruitless unless there is a critical bug. :) (and note that npm releases are a week behind because current release are pre-releases.) |
@Fishrock123 I just realized after leaving the comments :D I removed them immediately. Looks like our deps updates need just a green CI run if applicable. |
The regular CI doesn't and can't test npm. There is a special CI job for it, but it hasn't been used and doesn't work very well for a variety of reasons, including that npm tests don't work so well on windows, and also the stuff that #1984 now attempts to patch over. |
@Fishrock123 Hmmm, would smoke testing project be a good place to include |
@thefourtheye I don't necessarily think it has to be, or should be, even if it could be. |
PR-URL: #2152 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Thanks, landed in 6c3aabf...cff7300 ... sorry for the delay! |
Notable changes * src: Added a new `--track-heap-objects` flag to track heap object allocations for heap snapshots (Bradley Meck) nodejs#2135. * readline: Fixed a freeze that affected the repl if the keypress event handler threw (Alex Kocharin) nodejs#2107. * npm: Upgraded to v2.13.0, release notes can be found in https://github.com/npm/npm/releases/tag/v2.13.0 (Forrest L Norvell) nodejs#2152. PR-URL: nodejs#2189
Now includes more
npm ping
, and also all the https://github.com/npm/npm/releases/tag/v2.13.0.r: @Fishrock123
r: @chrisdickinson
(note for @Fishrock123: are there any additional patches we should be cherry-picking? I thought I saw some additional
node-gyp
changes in a PR a week or so ago, but I noticed thatnpm@2.12.1
only had the same two cherry-picked patches.)