doc: fix setUncaughtExceptionCaptureCallback name in body text #21523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
addaleax
approved these changes
Jun 25, 2018
trivikr
approved these changes
Jun 25, 2018
trivikr
added
the
author ready
cjihrig
approved these changes
Jun 25, 2018
|
@rjoonas Thanks for the find, and the PR! 😄 |
vsemozhetbyt
approved these changes
Jun 25, 2018
vsemozhetbyt
added
the
fast-track
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
vsemozhetbyt
removed
the
fast-track
vsemozhetbyt
pushed a commit
that referenced
this pull request
Jun 27, 2018
setUncaughtExceptionCapture -> setUncaughtExceptionCaptureCallback process.setUncaughtExceptionCaptureCallback and its docs were originally added in #17159 PR-URL: #21523 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
|
Landed in 1f6adff Thank you, @rjoonas! |
targos
pushed a commit
that referenced
this pull request
Jun 28, 2018
setUncaughtExceptionCapture -> setUncaughtExceptionCaptureCallback process.setUncaughtExceptionCaptureCallback and its docs were originally added in #17159 PR-URL: #21523 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name of this function was misspelled in its Process docs, so I changed
setUncaughtExceptionCapturetosetUncaughtExceptionCaptureCallback.process.setUncaughtExceptionCaptureCallbackand its docs were originally added in #17159Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes