tls: throw when unable to set ciphers #21557
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR both clarifies the
ciphers
option for tls connections and makestls.createSecureContext()
throw (with an OpenSSL error message) ifciphers
is not acceptable.It may be worth mimicking this same behavior for other setter functions. While most others at least throw a generic error (while
SetCiphers()
silently ignored the return value when setting ciphers), I think tweaking those to include the OpenSSL error may be more helpful.CI: https://ci.nodejs.org/job/node-test-pull-request/15648/
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes