test: properly clean up temp directory #2164
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| throw e; | ||
| } | ||
| } | ||
|
|
||
| process.chdir(dir); | ||
| assert(process.cwd() == dir); | ||
|
|
||
| process.chdir('..'); | ||
| assert(process.cwd() == path.resolve(common.fixturesDir)); |
There was a problem hiding this comment.
I have actually consistently seen this assertion fail on 10.11
There was a problem hiding this comment.
Yes, that's what I was seeing to. Thanks for confirming.
There was a problem hiding this comment.
Actually, it fails on assert(process.cwd() == dir); already right now.
|
LGTM if CI is happy |
silverwind
added a commit
that referenced
this pull request
Jul 11, 2015
A persistent failure on OS X 10.11 uncovered a inproperly cleaned up temp directory in this test. This changes the mkdirSync call to clean up properly in case it throws. PR-URL: #2164 Reviewed-By: Evan Lucas <evanlucas@me.com>
|
Lots of unrelated failures in the CI. Landed in d4ceb16. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test didn't clean up its temp directory when the
mkdirSynccall fails, which broke future runs of this test withEEXISTerrors. This change ensures the temp directory is always cleaned up.The reason I encountered this is because it seems to be a persistent failure on OS X 10.11, at least on my machine.