Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: named anonymous functions in _stream_readable.js #21750

Closed
wants to merge 1 commit into from
Closed

stream: named anonymous functions in _stream_readable.js #21750

wants to merge 1 commit into from

Conversation

radsimu
Copy link
Contributor

@radsimu radsimu commented Jul 11, 2018 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the stream Issues and PRs related to the stream subsystem. label Jul 11, 2018
@trivikr
Copy link
Member

trivikr commented Jul 11, 2018 •
edited
Loading

Thank you @radsimu for your first PR to Node.js core! 🎉

CI: https://ci.nodejs.org/job/node-test-pull-request/15796/

@trivikr trivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 11, 2018
@trivikr
Copy link
Member

trivikr commented Jul 11, 2018

ToDo while pushing the code: rename http to stream in commit message

@BridgeAR BridgeAR changed the title http: named anonymous functions in _stream_readable.js stream: named anonymous functions in _stream_readable.js Jul 12, 2018
@trivikr
Copy link
Member

trivikr commented Jul 18, 2018

Resumed CI https://ci.nodejs.org/job/node-test-pull-request/15927/

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jul 18, 2018
@radsimu @BridgeAR
stream: named anonymous functions in _stream_readable.js
7e4e04d 
PR-URL: nodejs#21750
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR
Copy link
Member

Landed in 7e4e04d

@radsimu congratulations on your first commit to Node.js! 🎉 Keep it coming :-)

@BridgeAR BridgeAR closed this Jul 18, 2018
targos pushed a commit that referenced this pull request Jul 19, 2018
@radsimu @targos
stream: named anonymous functions in _stream_readable.js
d0c16f4 
PR-URL: #21750
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@targos targos mentioned this pull request Jul 31, 2018
Merged
This was referenced Aug 1, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@radsimu @trivikr @BridgeAR @jasnell @lpinca @nodejs-github-bot