[v8.x backport] src: fix compiler warning in process.ppid #21760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a compiler warning with SetAccessor() by passing in the context. PR-URL: nodejs#16958 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
nodejs-github-bot
added
c++
addaleax
approved these changes
Jul 11, 2018
MylesBorins
pushed a commit
that referenced
this pull request
Jul 13, 2018
This commit fixes a compiler warning with SetAccessor() by passing in the context. Backport-PR-URL: #21760 PR-URL: #16958 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
|
landed in c7b1976 |
rvagg
pushed a commit
that referenced
this pull request
Aug 16, 2018
This commit fixes a compiler warning with SetAccessor() by passing in the context. Backport-PR-URL: #21760 PR-URL: #16958 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a compiler warning with SetAccessor() by
passing in the context.
PR-URL: #16958
Reviewed-By: Anna Henningsen anna@addaleax.net
Reviewed-By: Gireesh Punathil gpunathi@in.ibm.com
Reviewed-By: Timothy Gu timothygu99@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Daniel Bevenius daniel.bevenius@gmail.com
Reviewed-By: Franziska Hinkelmann franziska.hinkelmann@gmail.com
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesBackport as requested of #16958