punycode: named anonymous functions

[venetah]

punycode: named anonymous functions

Refs: #8913

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[jasnell]

The punycode module is a legacy third-party vendored-in module that is currently deprecated and only used when ICU is not present or someone is specifically calling require('punycode'). I don't believe we should be making any changes to this module, even if largely cosmetic.

[Trott]

@jasnell It looks like we use punycode 2.0.0 but 2.1.1 is the most recent. Would you be open to the idea that a non-breaking update to 2.1.1 is appropriate? (Trying to redirect @venetah to a different good first contribution. Although I wonder if there would be lint failures...but first thing's first. Is it even an option in your view?)

[jasnell]

I'm not opposed to updating version of the module, but any changes to the module itself should be done upstream

[Trott]

FWIW, we did change four lines of the module in 2e568d9. But that can be floated again if necessary. (I would say it's not necessary. Simply don't land the change on v6.x and it should be fine, especially for something legacy/deprecated.)

Looks like there are no lint errors either... EDIT: ...because punycode is in the eslintignore file...

[Trott]

@venetah How would you feel about closing this PR and trying again with a punycode.js upgrade PR? I think you could do it this way (using UNIX-y commands, you will need to modify if you are on Windows):

• create a new branch starting with the current master branch
• grab version 2.1.1 of punycode.js from somewhere. This is one way:

$ mkdir tmp-dir && cd tmp-dir && npm install punycode@2.1.1
...
$ cp node_modules/punycode/punycode.js PATH_TO_punycode.js_IN_NODE

(You can remove tmp-dir after that.)

• Build with the new punycode with make -j4.
• Run tests with make test
• If everything looks good, open a pull request.

/cc @trivikr

[BridgeAR]

I am going to close this due to the mentioned reasons.

@venetah thanks a lot for your contribution! It is highly appreciated. Please also feel encouraged to follow up on the suggestion from @Trott

[Trott]

@venetah I've opened a pull request for the punycode update. If this is something you were planning on doing, let me know and I'll close mine or at least marked it as blocked pending yours.