tools: update ESLint to 5.2.0

[hiroppy]

changelog: https://github.com/eslint/eslint/releases/tag/v5.1.0 https://github.com/eslint/eslint/releases/tag/v5.2.0

CI: https://ci.nodejs.org/job/node-test-pull-request/15882/

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

[nodejs-github-bot]

@hiroppy build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/277/pipeline

[Trott]

It appears that most of the 179 package.json file changes (of the 205 total changed files here) are simply changes like this. This is definitely churn we don't need. Any chance we can omit the package.json files that only change the _where path from the commit? I'll work on a PR to update update-eslint.sh to do this automatically.

[Trott]

(PR: #21819)

[hiroppy]

good catch! thanks @Trott. I will wait for #21819 to be merged.

[hiroppy]

node-test-commit-osx failed but it has no related this PR.

20:24:08 not ok 2340 sequential/test-timers-blocking-callback
20:24:08   ---
20:24:08   duration_ms: 2.301
20:24:08   severity: fail
20:24:08   exitcode: 1
20:24:08   stack: |-
20:24:08     assert.js:80
20:24:08       throw new AssertionError(obj);
20:24:08       ^
20:24:08     
20:24:08     AssertionError [ERR_ASSERTION]: timeout delayed by more than 100% (250ms)
20:24:08         at blockingCallback (/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1012/test/sequential/test-timers-blocking-callback.js:62:14)
20:24:08         at ontimeout (timers.js:457:11)
20:24:08         at tryOnTimeout (timers.js:327:5)
20:24:08         at listOnTimeout (timers.js:301:5)
20:24:08         at processTimers (timers.js:258:5)

[Trott]

@hiroppy It's a known flaky. See #21781. You can use "Resume Build" on the node-test-pull-request page for your CI run to create a new node-test-pull-request that will keep all the green from that run and re-run everything else. (Although I think we'll need a full CI re-run once you remove the package.json files from the commit.)

[Trott]

Change to update-eslint.sh has landed so I've removed the blocked label. This will still have a bigger-than-usual diff because the new update-eslint.sh will remove a bunch of unnecessary stuff from all of the package.json files, but after this lands, that won't happen again. 🎉

[hiroppy]

Used the patch created by @Trott and updated ESLint to 5.2.0.

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/15977/

[Trott]

Resumed CI: https://ci.nodejs.org/job/node-test-pull-request/16018/

[Trott]

@nodejs/linting This could use another review or so.

[silverwind]

Two points:

1. This release should bring support for some globals we manually define, so you should be able to remove them.
2. From the diff, I'm not sure if eslint's dependencies were actually updated because the diff does not contain updated files for globals, for example.

[Trott]

2. From the diff, I'm not sure if eslint's dependencies were actually updated because the diff does not contain updated files for globals, for example.

@silverwind Current master branch (with ESLint 5.0.0) has globals 11.7.0, which is the most recent release. So I wouldn't expect an update to ESLint 5.2.0 to change that. It's still going to be globals 11.7.0. (Or maybe I'm misunderstanding?)

[silverwind]

Current master branch (with ESLint 5.0.0) has globals 11.7.0

Ah, you're right. I actually attempted to remove those globals earlier on master but it wasn't working for some weird reason.

[silverwind]

Just re-tested the removals of the globals, still didn't work out despite having the globals in tools/node_modules/eslint/node_modules/globals/globals.json. Have to check it out another time, so should be LGTM.

[Trott]

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/16023/

[jasnell]

rubber-stamp lgtm

[Trott]

That one macstadium OSX 12 machine just doesn't want to build...

Trying again: https://ci.nodejs.org/job/node-test-pull-request/16032/

[Trott]

https://ci.nodejs.org/job/node-test-pull-request/16037/

[Trott]

Landed in 8c6d1a0