Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix vm.runInNewContext signature #21824

Closed
wants to merge 1 commit into from
Closed

doc: fix vm.runInNewContext signature #21824

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Jul 15, 2018

The options parameter cannot be passed without sandbox.

Checklist

@targos
doc: fix vm.runInNewContext signature
d52bfac 
The `options` parameter cannot be passed without `sandbox`.
@nodejs-github-bot
Copy link
Collaborator

@targos build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/280/pipeline

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. vm Issues and PRs related to the vm subsystem. labels Jul 15, 2018
@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 15, 2018
@targos
Copy link
Member Author

targos commented Jul 15, 2018

Please 👍 this comment to fast-track.

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 15, 2018
@addaleax
Copy link
Member

Landed in d279a8f

@addaleax addaleax closed this Jul 15, 2018
addaleax pushed a commit that referenced this pull request Jul 15, 2018
@targos @addaleax
doc: fix vm.runInNewContext signature
d279a8f 
The `options` parameter cannot be passed without `sandbox`.

PR-URL: #21824
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos added a commit that referenced this pull request Jul 16, 2018
@targos
doc: fix vm.runInNewContext signature
51dfebf 
The `options` parameter cannot be passed without `sandbox`.

PR-URL: #21824
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targos targos mentioned this pull request Jul 17, 2018
Merged
@targos targos deleted the fix-vm-doc branch July 18, 2018 06:03
This was referenced Jul 18, 2018
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@targos @nodejs-github-bot @addaleax @lpinca @TimothyGu @vsemozhetbyt