deps: backport crypto/init.c fix for openssl110 #21848
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The statically linked program should not try to keep loaded by dlopen trick. Fixes: nodejs#21845 Refs: openssl/openssl#6725
nodejs-github-bot
added
the
openssl
|
/cc @nodejs/crypto @tniessen |
|
I’m going to label this as “blocked” until the upstream PR is merged – thanks for taking care of this issue! |
|
Closing this since the upstream PR seems to be stalled. Please feel free to reopen this. |
|
There seems to have been a fix for that (see |
|
@lal12 do you care to make a PR? Just adding a define to the gyp file should be straightforward. I can even do it, but I'd need way more info. I gather you suggest adding OPENSSL_NO_PINSHARED? But only for Node.js 8.x, since 10.x and higher use openssl 1.1.1? Though 10.x supports being built against an external openssl 1.1.0, so it may apply. /cc @shigeki @nodejs/crypto |
|
I am not that familiar with the gyp build system. But I will try.
The flag was only added in the newest openssl (I think 1.1.1b) versions. So
I am not exactly sure how that is handled, will the newest openssl patch
version be backported? Seems to be the correct way of doing it to me. Or
will just the fix with the flag be backported to Node's internal openssl?
I would start making a PR for the master? Correct?
|
|
Look in common.gypi in top-level of repo for other `OPENSSL_blah_blah`
defines. Change it there, then run `./configure`.
Change would be to master. It will be backported (by us, you don't
have to do anything) to all branches that have openssl 1.1.1 and are
supported (i.e., to 12.x and 10.x).
Thanks!
|
2 tasks
lal12
added a commit
to lal12/node
that referenced
this pull request
Jun 4, 2019
OpenSSL dlloads itself to prevent unloading, in case it might be dynamically loaded. However when linked statically this will lead to dloading the main executable. Fixes: nodejs#27925 Refs: nodejs#21848 (comment)
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Jul 30, 2019
OpenSSL dlloads itself to prevent unloading, in case it might be dynamically loaded. However when linked statically this will lead to dloading the main executable. Refs: nodejs#21848 (comment) PR-URL: nodejs#28045 Fixes: nodejs#27925 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 2, 2019
OpenSSL dlloads itself to prevent unloading, in case it might be dynamically loaded. However when linked statically this will lead to dloading the main executable. Refs: #21848 (comment) PR-URL: #28045 Fixes: #27925 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
AshCripps
pushed a commit
to AshCripps/node
that referenced
this pull request
Oct 17, 2019
OpenSSL dlloads itself to prevent unloading, in case it might be dynamically loaded. However when linked statically this will lead to dloading the main executable. Refs: nodejs#21848 (comment) Fixes: nodejs#29992 PR-URL: nodejs#28045 Fixes: nodejs#27925 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
2 tasks
BethGriggs
pushed a commit
that referenced
this pull request
Oct 17, 2019
OpenSSL dlloads itself to prevent unloading, in case it might be dynamically loaded. However when linked statically this will lead to dloading the main executable. Refs: #21848 (comment) Fixes: #29992 Backport-PR-URL: #30005 PR-URL: #28045 Fixes: #27925 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The statically linked program should not try to keep loaded
by dlopen trick.
Fixes: #21845
Refs: openssl/openssl#6725
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes