util: harden util.inspect #21869
Closed
util: harden util.inspect #21869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sure values without prototype will still be inspected properly and do not cause errors. It restores the original information if possible. Besides that it fixes an issue with boxed symbols: extra keys were not visualized so far.
nodejs-github-bot
added
the
util
devsnek
approved these changes
Jul 18, 2018
|
PTAL. It would be nice to get another LG. @devsnek are you also fine with landing it as is? |
jdalton
reviewed
Jul 27, 2018
lib/util.js
Outdated
| if (ctx.showHidden) { | ||
| formatter = formatWeakSet; | ||
| } else { | ||
| extra = '<items unknown>'; | ||
| } | ||
| } else if (isWeakMap(value)) { | ||
| braces[0] = `${getPrefix(constructor, tag)}{`; | ||
| braces[0] = `${getPrefix(constructor, tag) || 'WeakMap '}{`; |
There was a problem hiding this comment.
Would it make more sense to make the || 'thing ' be a param of getPrefix to add the trailing space then?
|
I addressed both comments. |
jasnell
approved these changes
Jul 27, 2018
jdalton
approved these changes
Jul 27, 2018
devsnek
approved these changes
Jul 27, 2018
|
Landed in 10c850b 🎉 |
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Jul 27, 2018
This makes sure values without prototype will still be inspected properly and do not cause errors. It restores the original information if possible. Besides that it fixes an issue with boxed symbols: extra keys were not visualized so far. PR-URL: nodejs#21869 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
4 tasks
|
#20961 landed and I was able to cherry-pick this with just a trivial conflict to fix. |
This was referenced Aug 19, 2018
targos
pushed a commit
that referenced
this pull request
Aug 19, 2018
This makes sure values without prototype will still be inspected properly and do not cause errors. It restores the original information if possible. Besides that it fixes an issue with boxed symbols: extra keys were not visualized so far. PR-URL: #21869 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
|
@targos seems like this did not yet land in any release. I would like to pull this out until #22437 landed. In that case both could land together. Otherwise the latter would be semver-major as I remove support for the Symbol.manipulation again. It is just difficult to deal with that properly all at once. |
|
@targos yes, awesome. Thanks a lot. |
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
This makes sure values without prototype will still be inspected properly and do not cause errors. It restores the original information if possible. Besides that it fixes an issue with boxed symbols: extra keys were not visualized so far. PR-URL: #21869 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
This was referenced Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure values without prototype will still be inspected
properly and do not cause errors. It restores the original
information if possible.
Besides that it fixes an issue with boxed symbols: extra keys were
not visualized so far.
The main focus here is correctness and performance. I am not always happy with the code but it is not always easy to "fix" these things. I could not find a fix for e.g. regular expressions and if someone has an idea, please let me know!
Fixes #19511
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes