Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v10.x] http: allow url and options to be passed to http*.request and http*.get #21880

Closed
wants to merge 2 commits into from
Closed

[v10.x] http: allow url and options to be passed to http*.request and http*.get #21880

wants to merge 2 commits into from

Conversation

targos
Copy link
Member

@targos targos commented Jul 19, 2018 •
edited
Loading

Backport of #21616

@targos targos added the v10.x label Jul 19, 2018
@nodejs-github-bot
Copy link
Collaborator

@targos build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/313/pipeline

@targos
Copy link
Member Author

targos commented Jul 19, 2018 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/15943/
Edit: resumed build: https://ci.nodejs.org/job/node-test-pull-request/15947/

@targos
Copy link
Member Author

targos commented Jul 20, 2018

@nodejs/http

@targos
Copy link
Member Author

targos commented Jul 24, 2018

Ping

@trivikr
Copy link
Member

trivikr commented Jul 27, 2018

\cc @rubys

@rubys @targos
http: allow url and options to be passed to http*.request and http*.get
4436efc 
Fixes: nodejs#20795
PR-URL: nodejs#21616
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@rubys @targos
https: allow url and options to be passed to https.request
0c748a4 
PR-URL: nodejs#22003
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos
Copy link
Member Author

targos commented Aug 2, 2018 •
edited
Loading

Rebased and added #22003. PTAL.
CI: https://ci.nodejs.org/job/node-test-pull-request/16158/
Edit: rebuild https://ci.nodejs.org/job/node-test-commit-linuxone/3528/

@targos targos added http Issues or PRs related to the http subsystem. https Issues or PRs related to the https subsystem. labels Aug 2, 2018
@targos
Copy link
Member Author

targos commented Aug 4, 2018

Ping @trivikr since I added a new commit.
Ping @rubys this backports two of your PRs.

@targos
Copy link
Member Author

targos commented Aug 6, 2018

Summoning @nodejs/collaborators. I'm desperately waiting for reviews :)

@targos targos added the semver-minor PRs that contain new features and should be released in the next minor version. label Aug 6, 2018
Trott
Trott approved these changes Aug 6, 2018
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

mcollina
mcollina approved these changes Aug 6, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

targos pushed a commit that referenced this pull request Aug 7, 2018
@rubys @targos
http: allow url and options to be passed to http*.request and http*.get
37369eb 
Fixes: #20795
PR-URL: #21616
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

Backport-PR-URL: #21880
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos pushed a commit that referenced this pull request Aug 7, 2018
@rubys @targos
https: allow url and options to be passed to https.request
2bf9a4a 
PR-URL: #22003
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Backport-PR-URL: #21880
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@targos
Copy link
Member Author

targos commented Aug 7, 2018

Thank you! Landed in 37369eb and 2bf9a4a

@targos targos closed this Aug 7, 2018
@targos targos deleted the backport-21616 branch August 7, 2018 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@Trott Trott Trott approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem. https Issues or PRs related to the https subsystem. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@targos @nodejs-github-bot @trivikr @mcollina @Trott @rubys